feat: Enable ALTS hard bound token in Bigtable w/ direct access #2695
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
rockspore
force-pushed
the
bigtable-alts-bound-token
branch
from
2cf12e6 to
90e032f
Compare
rockspore
force-pushed
the
bigtable-alts-bound-token
branch
from
90e032f to
c296c92
Compare
product-auto-label
bot
added
size: xs
sushanb
reviewed
Oct 17, 2025
| .setAttemptDirectPath(true) | ||
| // Try to fetch a hard-bound access token for direct access if the runtime | ||
| // environment supports it. | ||
| .setAllowHardBoundTokenTypes( |
There was a problem hiding this comment.
You can set it as default. Not a hard requirement, but could we add a env var to disable this incase we have any problem? Better to use env var rather than rollback client to prev version.
There was a problem hiding this comment.
This is a great point. Done. Thanks for the tip!
sushanb
previously approved these changes
Oct 17, 2025
product-auto-label
bot
added
size: s
sushanb
approved these changes
Oct 23, 2025
|
@sushanb Thanks for approving the PR. I doubt the CI failure was due to the change here. Could you help rerun it? |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.